Skip to content

fix(@angular/build): include custom bundle name scripts with karma #30536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Jun 13, 2025

When using the karma builder with custom "scripts" option entries that contain the bundleName suboption, the output files for these scripts will now correctly be injected into the test index HTML content. Previously only the default scripts.js output file would be used.

When using the `karma` builder with custom "scripts" option entries that
contain the `bundleName` suboption, the output files for these scripts
will now correctly be injected into the test index HTML content. Previously
only the default `scripts.js` output file would be used.
@clydin clydin added the target: patch This PR is targeted for the next patch release label Jun 13, 2025
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 13, 2025
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 13, 2025
@clydin clydin merged commit 049e688 into angular:main Jun 13, 2025
56 of 58 checks passed
@clydin
Copy link
Member Author

clydin commented Jun 13, 2025

The changes were merged into the following branches: main, 20.0.x

@clydin clydin deleted the karma/scripts-bundle-name branch June 13, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants