Skip to content

fix(@angular/build): include extracted routes in the manifest during prerendering #29428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

alan-agius4
Copy link
Collaborator

This commit ensures that extracted routes are added to the manifest during prerendering. This guarantees a correct ng-server-context value for parameterized routes and provides a performance benefit by preventing route extraction from being repeated for every rendering worker.

Closes #29426

…prerendering

This commit ensures that extracted routes are added to the manifest during prerendering. This guarantees a correct ng-server-context value for parameterized routes and provides a performance benefit by preventing route extraction from being repeated for every rendering worker.

Closes angular#29426
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jan 21, 2025
@alan-agius4 alan-agius4 requested a review from clydin January 21, 2025 12:59
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 21, 2025
@alan-agius4 alan-agius4 marked this pull request as ready for review January 21, 2025 12:59
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 21, 2025
@alan-agius4 alan-agius4 merged commit 395562a into angular:main Jan 21, 2025
35 checks passed
@alan-agius4 alan-agius4 deleted the server-context-ssg branch January 21, 2025 20:08
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.1.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng-server-context="ssr" on prerendered (SSG) parameterized routes
2 participants