feat(@angular-devkit/architect): merge object options from CLI #28398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently introduced the ability to pass object values from the command line (#28362). @clydin noticed that the initial behavior didn't work well for
--define
: It completely replaced all values even if just one of multiple defines is specified.This updates the architect to support merging of object options. If both the base option (e.g. from
angular.json
) and the override (e.g. from a CLI--flag
) are objects, the objects are merged.See: #28362
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
With multiple
define
s inangular.json
, passing any define via the--define
flag will ignore all existing defines.What is the new behavior?
Only defines specified via the
--define
flag will be replaced. All others retain the value specified inangular.json
.Does this PR introduce a breaking change?
Other information