Skip to content

fix(@angular/build): do not reference sourcemaps in web workers and global stylesheet bundles when hidden setting is enabled #27838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

alan-agius4
Copy link
Collaborator

This commit addresses an issue where sourcemaps in web workers and global stylesheets were referenced despite the hidden setting being enabled.

Closes: #27833

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 13, 2024
@alan-agius4 alan-agius4 requested a review from clydin June 13, 2024 09:46
@alan-agius4 alan-agius4 self-assigned this Jun 13, 2024
…lobal stylesheet bundles when hidden setting is enabled

This commit addresses an issue where sourcemaps in web workers and global stylesheets were referenced despite the hidden setting being enabled.

Closes: angular#27833
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 13, 2024
@clydin clydin merged commit 8c37926 into angular:main Jun 13, 2024
37 checks passed
@clydin
Copy link
Member

clydin commented Jun 13, 2024

The changes were merged into the following branches: main, 18.0.x

@alan-agius4 alan-agius4 deleted the hidden-sm branch June 13, 2024 12:22
@csvn
Copy link

csvn commented Jun 13, 2024

Awesome, that was really quick. Thanks!🎉

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worker and global style files do not respect sourceMap.hidden
3 participants