Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/schematics): SchematicTestRunner.runExternalSchematic fails with "The encoded data was not valid for encoding utf-8" #27644

Merged
merged 1 commit into from
May 15, 2024

Conversation

alan-agius4
Copy link
Collaborator

When using Jest instanceof does not work correctly. See: jestjs/jest#2549

Closes: #27643

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels May 15, 2024
@alan-agius4 alan-agius4 requested a review from clydin May 15, 2024 15:07
@alan-agius4 alan-agius4 marked this pull request as ready for review May 15, 2024 15:07
…matic` fails with "The encoded data was not valid for encoding utf-8"

When using Jest instanceof does not work correctly. See: jestjs/jest#2549

Closes: angular#27643
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 15, 2024
@alan-agius4 alan-agius4 merged commit 7b52b98 into angular:main May 15, 2024
33 checks passed
@alan-agius4 alan-agius4 deleted the type-error branch May 15, 2024 15:17
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SchematicTestRunner.runExternalSchematic fails with "The encoded data was not valid for encoding utf-8"
2 participants