Skip to content

fix(@angular-devkit/build-angular): Windows Node.js 20 prerendering failure #26186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

alan-agius4
Copy link
Collaborator

On Node.js 20 prerendering failed on Windows with An unhandled exception occurred: No handler function exported error. This appears to be caused by transforming Piscina CJS bundles using the JavaScriptTransformer. interestingly, this does not effect other OS like Linux and Mac.

…ailure

On Node.js 20 prerendering failed on Windows with `An unhandled exception occurred: No handler function exported` error. This appears to be caused by transforming Piscina CJS bundles using the `JavaScriptTransformer`. interestingly, this does not effect other OS like Linux and Mac.
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Oct 31, 2023
@alan-agius4 alan-agius4 requested a review from clydin October 31, 2023 09:36
…ering failure

Co-authored-by: Charles <19598772+clydin@users.noreply.github.com>
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker merge: squash commits When the PR is merged, a squash and merge should be performed and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 31, 2023
@alan-agius4 alan-agius4 merged commit dbb6329 into angular:main Oct 31, 2023
@alan-agius4 alan-agius4 deleted the windows-20-ci branch October 31, 2023 14:32
alan-agius4 added a commit that referenced this pull request Oct 31, 2023
…ailure (#26186)

* fix(@angular-devkit/build-angular): Windows Node.js 20 prerendering failure

On Node.js 20 prerendering failed on Windows with `An unhandled exception occurred: No handler function exported` error. This appears to be caused by transforming Piscina CJS bundles using the `JavaScriptTransformer`. interestingly, this does not effect other OS like Linux and Mac.

* fixup! fix(@angular-devkit/build-angular): Windows Node.js 20 prerendering failure

Co-authored-by: Charles <19598772+clydin@users.noreply.github.com>

---------

Co-authored-by: Charles <19598772+clydin@users.noreply.github.com>
(cherry picked from commit dbb6329)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker merge: squash commits When the PR is merged, a squash and merge should be performed target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants