fix(@angular-devkit/build-angular): experimental esbuild pipeline, add es2015 to main fields for RxJS v6 compatibility
#25406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d `es2015` to main fields for RxJS v6 compatibility Currently, for RxJS v6, no conditions are available, and the ESBuild pipeline will select the ES5 distribution based on the `module` main field. This is fine in most cases, but applications could benefit from better optimization with the use of the ES2015 output + there are certain code differences that currently would cause runtime breakages when e.g. `rxjs/testing` is used. See: angular#25405 for more details. Fixes angular#25405.
devversion
added
the
action: review
clydin
approved these changes
Jun 20, 2023
devversion
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for RxJS v6, no conditions are available, and the ESBuild pipeline will select the
ES5 distribution based on the
modulemain field. This is fine in most cases, but applicationscould benefit from better optimization with the use of the ES2015 output + there are certain
code differences that currently would cause runtime breakages when e.g.
rxjs/testingis used.See: #25405 for more details.
Fixes #25405.