Skip to content

fix(@schematics/angular): provide migration that disables build optimizer on dev server builds #25084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alan-agius4
Copy link
Collaborator

In #25070 we turned on buildOptimizer by default for server builds. This causes existing projects development builds to always run build-optimizer. This migration will set buildOptimizer to false, when optimization is disabled.

…izer on dev server builds

In angular#25070 we turned on `buildOptimizer` by default for server builds. This causes existing projects development builds to always run build-optimizer. This migration will set `buildOptimizer` to false, when `optimization` is disabled.
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Apr 27, 2023
@alan-agius4 alan-agius4 requested a review from clydin April 27, 2023 09:57
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 27, 2023
@angular-robot angular-robot bot merged commit 873272f into angular:main Apr 27, 2023
@alan-agius4 alan-agius4 deleted the server-migration-build-optimizer branch April 27, 2023 12:40
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants