Skip to content

Migrate to GA4 #24015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2022
Merged

Migrate to GA4 #24015

merged 4 commits into from
Oct 11, 2022

Conversation

alan-agius4
Copy link
Collaborator

No description provided.

@alan-agius4 alan-agius4 added this to the v15 Feature Freeze milestone Oct 5, 2022
@alan-agius4 alan-agius4 force-pushed the analytics-js branch 3 times, most recently from 03d880a to 7722a3c Compare October 6, 2022 13:27
# Metrics

### List of All Metrics
### List Of Event Custom Metrics
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still sceptic about the usefulness of the below.

@alan-agius4 alan-agius4 requested a review from clydin October 6, 2022 14:00
@alan-agius4 alan-agius4 marked this pull request as ready for review October 6, 2022 14:00
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Oct 6, 2022
@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Oct 6, 2022

Following a convo with @mgechev we should include

  • ngComponentCount
  • totalCssSize
  • totalJsSize

@alan-agius4 alan-agius4 force-pushed the analytics-js branch 2 times, most recently from eac2004 to ab7db1c Compare October 7, 2022 08:52
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 7, 2022
This change updates the analytics collector collector to use GA4 instead of UA. The motivation behind this change is that UA will stop collecting data in 2023.

BREAKING CHANGE:

`analyticsSharing` option in the global angular configuration has been
removed without replacement. This option was used to configure the Angular CLI to  access to your own users' CLI usage data.

If this option is used, it can be removed using `ng config --global cli.analyticsSharing undefined`.
All analytics is now in the @angular/cli package

BREAKING CHANGE: analytics APIs have been removed without replacement from `@angular-devkit/core` and `@angular-devkit/architect`.
The new build and rebuild statistics are used by the CLI to submit build related information to GA.

### List Of All Dimensions
### List of User Custom Dimensions
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgechev since @dgp1130 is OOO can you please take a look the new list of data collected?

@alan-agius4 alan-agius4 requested a review from mgechev October 11, 2022 13:52
| Command | `ep.ng_command` | `string` |
| SchematicCollectionName | `ep.ng_schematic_collection_name` | `string` |
| SchematicName | `ep.ng_schematic_name` | `string` |
| Standalone | `ep.ng_standalone` | `string` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This collects only --standalone flag, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member

@mgechev mgechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It'll be fantastic if we can collect the number of standalone components by looking at the metadata.

@alan-agius4
Copy link
Collaborator Author

LGTM. It'll be fantastic if we can collect the number of standalone components by looking at the metadata.

I’ll take a look a look at that as see if it’s feasible.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 11, 2022
@alan-agius4 alan-agius4 merged commit 5228c23 into angular:main Oct 11, 2022
@alan-agius4 alan-agius4 deleted the analytics-js branch October 11, 2022 16:52
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker flag: breaking change target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants