Skip to content

feat(@angular-devkit/build-angular): add ng-server-context when using app-shell builder #23951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2022
Merged

feat(@angular-devkit/build-angular): add ng-server-context when using app-shell builder #23951

merged 1 commit into from
Sep 23, 2022

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Sep 23, 2022 •
edited
Loading

With this change we configure the app-shell builder to set the ɵSERVER_CONTEXT private provider.

FYI @AndrewKushnir

@alan-agius4
feat(@angular-devkit/build-angular): add ng-server-context when usi…
6eaa5a5 
…ng app-shell builder

With this change we configure the app-shell builder to set the `ɵSERVER_CONTEXT` private provider.
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 23, 2022
@alan-agius4 alan-agius4 requested a review from clydin September 23, 2022 13:45
@alan-agius4 alan-agius4 added this to the v15 Feature Freeze milestone Sep 23, 2022
AndrewKushnir
AndrewKushnir approved these changes Sep 23, 2022
View reviewed changes
Copy link

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-agius4 thanks for adding this 👍

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 23, 2022
@clydin clydin merged commit 4ead45c into angular:main Sep 23, 2022
@alan-agius4 alan-agius4 deleted the add-server-context branch September 23, 2022 18:55
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
v15 Feature Freeze
Development

Successfully merging this pull request may close these issues.
3 participants
@alan-agius4 @clydin @AndrewKushnir