Remove karma.conf.js from newly generated projects #23950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
commented
Sep 23, 2022
packages/angular_devkit/build_angular/src/builders/karma/index.ts
Outdated
Show resolved
Hide resolved
alan-agius4
added
the
target: major
alan-agius4
force-pushed
the
make-karmaconfig-optional
branch
from
66df6a0 to
2c31799
Compare
alan-agius4
force-pushed
the
make-karmaconfig-optional
branch
2 times, most recently
from
13b636d to
08a6987
Compare
alan-agius4
added
action: review
alan-agius4
force-pushed
the
make-karmaconfig-optional
branch
5 times, most recently
from
1605558 to
b5495f4
Compare
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
make-karmaconfig-optional
branch
from
b5495f4 to
dbe7e51
Compare
clydin
reviewed
Sep 26, 2022
alan-agius4
force-pushed
the
make-karmaconfig-optional
branch
from
dbe7e51 to
c9e3771
Compare
alan-agius4
force-pushed
the
make-karmaconfig-optional
branch
6 times, most recently
from
51564c1 to
54894d8
Compare
…optional Karma will now use a builtin config when the `karmaConfig` is not specified.
…d projects `@angular-devkit/build-angular` now has a built in Karma config. Users can still create their own Karma configuration if they want to override the default configuration.
alan-agius4
force-pushed
the
make-karmaconfig-optional
branch
2 times, most recently
from
0965e6e to
9e01111
Compare
clydin
approved these changes
Sep 28, 2022
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(@schematics/angular): remove karma.conf.js from newly generated projects
@angular-devkit/build-angularnow has a built in Karma config. Users can still create their own Karma configuration if they want to override the default configuration.feat(@angular-devkit/build-angular): providing a karma config is now optional
Karma will now use a builtin config when the
karmaConfigis not specified.