fix(@angular-devkit/build-angular): show warning when using TypeScript target older then ES2022 in esbuild builder #23949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: major
alan-agius4
force-pushed
the
esbuild-warning-ts-target-old
branch
2 times, most recently
from
a808885 to
b0d5dac
Compare
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
esbuild-warning-ts-target-old
branch
2 times, most recently
from
a72573f to
4d4f9f7
Compare
alan-agius4
force-pushed
the
esbuild-warning-ts-target-old
branch
from
4d4f9f7 to
541355d
Compare
alan-agius4
force-pushed
the
esbuild-warning-ts-target-old
branch
from
541355d to
0a196f8
Compare
clydin
approved these changes
Oct 11, 2022
| notes: [ | ||
| { | ||
| text: `To control ECMA version and features use the Browerslist configuration. ' + | ||
| 'For more information, see https://github.com/browserslist/browsers§list'`, |
There was a problem hiding this comment.
Suggested change
| 'For more information, see https://github.com/browserslist/browsers§list'`, | |
| 'For more information, see https://github.com/browserslist/browserslist#queries'`, |
alan-agius4
added
action: merge
…t target older then ES2022 in esbuild builder This commits adds a warning similar to that in the Webpack builder.
alan-agius4
force-pushed
the
esbuild-warning-ts-target-old
branch
from
9459cde to
61cef0e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds a warning similar to that in the Webpack builder.