feat(@schematics/angular): remove Browserslist configuration files from projects #23897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
This migrations are no longer needed as multiple versions update is not allowed.
alan-agius4
force-pushed
the
browserlist-config-removal
branch
from
1d0ea00 to
819774c
Compare
alan-agius4
added
the
action: review
clydin
reviewed
Sep 12, 2022
packages/schematics/angular/migrations/migration-collection.json
Outdated
Show resolved
Hide resolved
| const defaultSupportedBrowsers = new Set(browserslist(DEFAULT_BROWSERS)); | ||
|
|
||
| for (const path of visit(tree.root)) { | ||
| const { defaults: browsersListConfig } = browserslist.parseConfig(tree.readText(path)); |
There was a problem hiding this comment.
If there are any other keys for custom sections, we should probably keep the file.
We could optionally cleanup the defaults section of the file but that might be more complex than needed.
There was a problem hiding this comment.
We can at least delete the config if contains the default browsers and old unsupported browsers that generate es5 output.
packages/schematics/angular/migrations/update-15/remove-browserslist-config.ts
Outdated
Show resolved
Hide resolved
clydin
approved these changes
Sep 13, 2022
…om projects The Browserslist configuration file is redundant as we set the defaults directly in @angular-devkit/build-angular. https://github.com/angular/angular-cli/blob/8da926966e9f414ceecf60b89acd475ce1b55fc5/packages/angular_devkit/build_angular/src/utils/supported-browsers.ts#L12-L19 With this commit, we remove the `.browserlistrc` configuration file from the schematics application template and through a migration in existing projects when the Browserslist query result matches the default. Users needing a finer grain support should still create a `.browserlistrc` in the root directory of the project.
alan-agius4
force-pushed
the
browserlist-config-removal
branch
from
819774c to
6bbfbfe
Compare
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Browserslist configuration file is redundant as we set the defaults directly in @angular-devkit/build-angular.
angular-cli/packages/angular_devkit/build_angular/src/utils/supported-browsers.ts
Lines 12 to 19 in 8da9269
With this commit, we remove the
.browserlistrcconfiguration file from the schematics application template and through a migration in existing projects when the Browserslist query result matches the default.Users needing a finer grain support should still create a
.browserlistrcin the root directory of the project.