feat(@angular-devkit/build-angular): export @angular/platform-server symbols in server bundle
#23866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
commented
Sep 7, 2022
packages/angular_devkit/build_angular/src/builders/server/platform-server-exports.js
Outdated
Show resolved
Hide resolved
Closed
3 tasks
alan-agius4
force-pushed
the
platform-exports
branch
from
b115e3f to
44c2654
Compare
alan-agius4
force-pushed
the
platform-exports
branch
from
44c2654 to
82649bc
Compare
alan-agius4
added
action: review
alan-agius4
changed the title
@angular/platform-server symbols in server bundle@angular/platform-server symbols in server bundle
alan-agius4
force-pushed
the
platform-exports
branch
from
47d7082 to
b8e5ca2
Compare
alan-agius4
force-pushed
the
platform-exports
branch
from
b8e5ca2 to
82649bc
Compare
alan-agius4
force-pushed
the
platform-exports
branch
from
48c25f6 to
9dce6cf
Compare
alan-agius4
force-pushed
the
platform-exports
branch
from
9dce6cf to
e310125
Compare
alan-agius4
removed
the
action: review
alan-agius4
force-pushed
the
platform-exports
branch
4 times, most recently
from
e863fde to
a32f64b
Compare
alan-agius4
added
the
action: review
clydin
reviewed
Sep 19, 2022
packages/schematics/angular/migrations/update-15/remove-platform-server-exports.ts
Outdated
Show resolved
Hide resolved
clydin
reviewed
Sep 19, 2022
packages/schematics/angular/migrations/update-15/remove-platform-server-exports_spec.ts
Outdated
Show resolved
Hide resolved
clydin
approved these changes
Sep 19, 2022
packages/schematics/angular/migrations/update-15/remove-platform-server-exports_spec.ts
Outdated
Show resolved
Hide resolved
…` symbols in server bundle This commit adds an internal file to export needed symbols from `@angular/platform-server` when building a server bundle. This is needed. This is needed so that DI tokens can be referenced and set at runtime outside of the bundle. Also, it adds a migration to remove these exports from the users files as otherwise an export collision would occur due to the same symbol being exported multiple times.
alan-agius4
force-pushed
the
platform-exports
branch
from
a32f64b to
b115ca7
Compare
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an internal file to export needed symbols from
@angular/platform-serverwhen building a server bundle. This is needed. This is needed so that DI tokens can be referenced and set at runtime outside of the bundle.Also, it adds a migration to remove these exports from the users files as otherwise an export collision would occur due to the same symbol being exported multiple times.