Skip to content

fix(@angular/cli): handle cases were having completion enabled but running in an older CLI workspace #23520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Jul 7, 2022

Previously when having completion enabled and the current workspaces has an older version of the Angular CLI installed in the terminal the below errors is show. This is because the older versions of the CLI do not implement this command. Now we exit gracefully.

The specified command ("completion") is invalid. For a list of available options,
run "ng help".

Did you mean "analytics"?

Closes #23518

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jul 7, 2022
@alan-agius4 alan-agius4 requested a review from clydin July 7, 2022 08:09
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 7, 2022
@alan-agius4 alan-agius4 force-pushed the completion-command branch 4 times, most recently from d3717c1 to 59ad7d8 Compare July 7, 2022 13:36
@alan-agius4 alan-agius4 requested a review from clydin July 7, 2022 13:37
…g in an older CLI workspace

Previously when having completion enabled and the current workspaces has an older version of the Angular CLI installed in the terminal the below errors is show. This is because the older versions of the CLI do not implement this command. Now we exit gracefully.

```
The specified command ("completion") is invalid. For a list of available options,
run "ng help".

Did you mean "analytics"?
```

Closes angular#23518
@alan-agius4 alan-agius4 force-pushed the completion-command branch from 59ad7d8 to 7816d12 Compare July 7, 2022 17:42
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 7, 2022
@alan-agius4 alan-agius4 merged commit 2731fe7 into angular:main Jul 7, 2022
@alan-agius4 alan-agius4 deleted the completion-command branch July 7, 2022 18:39
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

14.0.5 not installed globaly
2 participants