Skip to content

fix(@angular-devkit/schematics): support ignore scripts package installs with Yarn 2+ #23243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2022

Conversation

clydin
Copy link
Member

@clydin clydin commented May 27, 2022

Yarn 2 and higher no longer support the --ignore-scripts flag.
The NodePackageInstallTask will now spawn Yarn with environment variables to ignore
scripts instead of the commandline option. Other package managers remain unchanged.
This provides the necessary functionality for the task without relying on Yarn
commandline options.

…lls with Yarn 2+

Yarn 2 and higher no longer support the `--ignore-scripts` flag.
The `NodePackageInstallTask` will now spawn Yarn with environment variables to ignore
scripts instead of the commandline option. Other package managers remain unchanged.
This provides the necessary functionality for the task without relying on Yarn
commandline options.
@clydin clydin added the target: rc This PR is targeted for the next release-candidate label May 27, 2022
@clydin clydin added this to the v14 milestone May 27, 2022
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 27, 2022
@clydin clydin merged commit 901f5dd into angular:main May 27, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants