Skip to content

docs: correct completion.gif image path #23220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2022

Conversation

alan-agius4
Copy link
Collaborator

Assets paths in AIO need to be relative. This also ensures that the base href element is respected if changed.

https://app.circleci.com/pipelines/github/angular/angular/46755/workflows/ea228e6e-62ab-4d7f-9764-2c1056ad0366/jobs/1173152

Assets paths in AIO need to be relative. This also ensures that the base href element is respected if changed.

https://app.circleci.com/pipelines/github/angular/angular/46755/workflows/ea228e6e-62ab-4d7f-9764-2c1056ad0366/jobs/1173152
@alan-agius4 alan-agius4 added the target: rc This PR is targeted for the next release-candidate label May 25, 2022
@alan-agius4 alan-agius4 requested a review from clydin May 25, 2022 12:43
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 25, 2022
@alan-agius4 alan-agius4 marked this pull request as ready for review May 25, 2022 12:43
@clydin clydin added this to the v14 milestone May 25, 2022
@dgp1130
Copy link
Collaborator

dgp1130 commented May 25, 2022

Darn it, I knew I was going to screw this up when I had to split that PR. Thanks for fixing this!

@dgp1130 dgp1130 merged commit b485e48 into angular:main May 25, 2022
@alan-agius4 alan-agius4 deleted the completion-doc-image-src branch May 25, 2022 18:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants