feat(@angular-devkit/build-angular): add initial experimental esbuild-based application browser builder #22995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
esbuild/initial-builder
branch
2 times, most recently
from
c18a2ca to
2f9522d
Compare
clydin
force-pushed
the
esbuild/initial-builder
branch
from
2f9522d to
2f61c76
Compare
alan-agius4
reviewed
Apr 16, 2022
packages/angular_devkit/build_angular/src/builders/browser-esbuild/compiler-plugin.ts
Outdated
Show resolved
Hide resolved
alan-agius4
reviewed
Apr 16, 2022
packages/angular_devkit/build_angular/src/builders/browser-esbuild/compiler-plugin.ts
Outdated
Show resolved
Hide resolved
alan-agius4
reviewed
Apr 16, 2022
packages/angular_devkit/build_angular/src/builders/browser-esbuild/stylesheets.ts
Outdated
Show resolved
Hide resolved
alan-agius4
reviewed
Apr 16, 2022
packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts
Outdated
Show resolved
Hide resolved
clydin
force-pushed
the
esbuild/initial-builder
branch
5 times, most recently
from
9bb0f20 to
1cd3c66
Compare
dgp1130
requested changes
Apr 21, 2022
Collaborator
dgp1130
left a comment
dgp1130
left a comment
There was a problem hiding this comment.
Awesome stuff! It actually comes together looking pretty simple in the end. I mostly have a bunch of nitpicks and questions, but overall it looks great!
packages/angular_devkit/build_angular/src/builders/browser-esbuild/compiler-plugin.ts
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/builders/browser-esbuild/compiler-plugin.ts
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/builders/browser-esbuild/compiler-plugin.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/builders/browser-esbuild/compiler-plugin.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/builders/browser-esbuild/compiler-plugin.ts
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/builders/browser-esbuild/options.ts
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/builders/browser-esbuild/stylesheets.ts
Outdated
Show resolved
Hide resolved
clydin
force-pushed
the
esbuild/initial-builder
branch
2 times, most recently
from
783f249 to
1ae9dec
Compare
dgp1130
reviewed
Apr 22, 2022
packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts
Show resolved
Hide resolved
clydin
force-pushed
the
esbuild/initial-builder
branch
from
1ae9dec to
3423807
Compare
dgp1130
approved these changes
Apr 22, 2022
Collaborator
dgp1130
left a comment
dgp1130
left a comment
There was a problem hiding this comment.
Looks great! I think some comments are still open but I don't have any major concerns with this.
packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts
Outdated
Show resolved
Hide resolved
…-based application browser builder An experimental browser application builder (`browser-esbuild`) has been introduced that leverages esbuild as the bundler. This new builder is compatible with options of the current browser application builder (`browser`) and can be enabled for experimentation purposes by replacing the `builder` field of `@angular-devkit/build-angular:browser` from an existing project to `@angular-devkit/build-angular:browser-esbuild`. The builder will generate an ESM-based application and provides support for ES2015+ compatible output with ES2020 as the default. This builder is considered experimental and is not recommended for production applications. Currently not all `browser` builder options and capabilities are supported with this experimental builder. Additional support for these options may be added in the future. The following options and capabilities are not currently supported: * Stylesheet Preprocessors (only CSS styles are supported) * Angular JIT mode (only AOT is supported) * Localization [`localize`] * Watch and dev-server modes [`watch`, `poll`, etc.] * File replacements [`fileReplacements`] * License text extraction [`extractLicenses`] * Bundle budgets [`budgets`] * Global scripts [`scripts`] * Build stats JSON output [`statsJson`] * Deploy URL [`deployURL`] * CommonJS module warnings (no warnings will be generated for CommonJS package usage) * Web Workers * Service workers [`serviceWorker`, `ngswConfigPath`]
The basic suite of E2E tests are now run against the newly introduced experimental esbuild-based builder (`browser-esbuild`). Several tests are currently ignored based on the current feature set of the builder.
clydin
force-pushed
the
esbuild/initial-builder
branch
from
3423807 to
c1b1c49
Compare
2 tasks
1 task
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An experimental browser application builder (
browser-esbuild) has been introduced that leverages esbuild as the bundler.This new builder is compatible with options of the current browser application builder (
browser) and can be enabledfor experimentation purposes by replacing the
builderfield of@angular-devkit/build-angular:browserfrom an existingproject to
@angular-devkit/build-angular:browser-esbuild. The builder will generate an ESM-based application and provides support for ES2015+ compatible output with ES2020 as the default.This builder is considered experimental and is not recommended for production applications.
Currently not all
browserbuilder options and capabilities are supported with this experimental builder. Additional support for these options may be added in the future.The following options and capabilities are not currently supported:
localize]watch,poll, etc.]fileReplacements]extractLicenses]budgets]scripts]statsJson]deployURL]serviceWorker,ngswConfigPath]