Skip to content

fix(@ngtools/webpack): don't elide decorated method parameter type reference #17083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2020
Merged

fix(@ngtools/webpack): don't elide decorated method parameter type reference #17083

merged 1 commit into from
Feb 26, 2020

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Feb 25, 2020

Fixes #17080
Reference: TOOL-1334

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Feb 25, 2020
@alan-agius4 alan-agius4 requested a review from clydin February 25, 2020 13:43
@@ -515,6 +515,8 @@ describe('@ngtools/webpack transformers', () => {
import { __decorate, __metadata } from "tslib";

import { Decorator } from './decorator';
import { Service } from './service';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 😱

@dgp1130 dgp1130 merged commit 678180e into angular:master Feb 26, 2020
@dgp1130
Copy link
Collaborator

dgp1130 commented Feb 26, 2020

Also merged to 9.0.x patch branch.

@alan-agius4 alan-agius4 deleted the decorator-metadata-parameter branch February 27, 2020 00:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decorated method can't resolve design:paramtypes
4 participants