Skip to content

fix(@angular/cli): expanded locale pattern in workspace schema for lo… #17033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

sacgrover
Copy link
Contributor

…cales field

Fixes: #17032

Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update here as well:

"pattern": "^[a-z]{2}(-[a-zA-Z]{2,})?$"

@clydin clydin added the target: patch This PR is targeted for the next patch release label Feb 20, 2020
@sacgrover
Copy link
Contributor Author

Sure, Sorry, I just noticed you made the same changes on same time.

@clydin
Copy link
Member

clydin commented Feb 20, 2020

No problem. Yours was quicker by 2 seconds so we can go with yours.

@sacgrover
Copy link
Contributor Author

@clydin I found two more instances. Do we need to update that as well?

"pattern": "^[a-z]{2}(-[a-zA-Z]{2,})?$"

"pattern": "^[a-z]{2}(-[a-zA-Z]{2,})?$"

@clydin
Copy link
Member

clydin commented Feb 20, 2020

Yes. Please do.

@sacgrover
Copy link
Contributor Author

Done

@clydin clydin added the action: merge The PR is ready for merge by the caretaker label Feb 20, 2020
@dgp1130 dgp1130 merged commit 764b977 into angular:master Feb 24, 2020
@dgp1130
Copy link
Collaborator

dgp1130 commented Feb 24, 2020

Also merged to patch branch (9.0.x).

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[I18n] New locale codes not supported by angular.json
4 participants