-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(@angular/cli): expanded locale pattern in workspace schema for lo… #17033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update here as well:
"pattern": "^[a-z]{2}(-[a-zA-Z]{2,})?$" |
Sure, Sorry, I just noticed you made the same changes on same time. |
No problem. Yours was quicker by 2 seconds so we can go with yours. |
236df9a
to
26a0656
Compare
@clydin I found two more instances. Do we need to update that as well?
|
Yes. Please do. |
26a0656
to
fcd5040
Compare
Done |
Also merged to patch branch (9.0.x). |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…cales field
Fixes: #17032