Skip to content

fix(@schematics/angular): improve i18n output path option migration #16412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Dec 10, 2019

Output paths that use the locale within a locale specific configuration will now be automatically removed. This will prevent the potential for the migrated configuration to generate an output path with double locale segments.

Closes #16384

@clydin clydin added the target: patch This PR is targeted for the next patch release label Dec 10, 2019
Output paths that use the locale within a locale specific configuration will now be automatically removed.  This will prevent the potential for the migrated configuration to generate an output path with double locale segments.
@clydin clydin force-pushed the i18n-improve-outputpath-migrations branch from 881709c to b400618 Compare December 10, 2019 19:13
@clydin clydin requested a review from alan-agius4 December 10, 2019 19:32
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyliau kyliau merged commit 3476674 into angular:master Dec 11, 2019
@clydin clydin deleted the i18n-improve-outputpath-migrations branch December 11, 2019 19:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng build with i18n creates extra layer of lang folders
4 participants