refactor(@angular-devkit/schematics): remove optimize from host-tree #15330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for this, can you please update the api golden file using the below command yarn bazel run //etc/api:angular_devkit_schematics_api.accept |
Contributor
Author
|
Thanks, update soon :) |
alan-agius4
added
PR state: blocked
target: major
Remove unused optimize method marked for removal in version 7.0
simjes
force-pushed
the
remove-todo-host-tree
branch
from
422ce42 to
1c3eddb
Compare
alan-agius4
approved these changes
Aug 14, 2019
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
Thanks, LGTM.
Blocking until version 9, since technically it removes a method from the Public API.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused optimize method marked for removal in version 7.0