fix(@angular/cli): schematics commands should fail on unknown options #13480
Conversation
alan-agius4
added
the
target: patch
When an addition argument is parsed the schematic commands should fail with an error. Fixes #12549
clydin
added
target: major
clydin
left a comment
clydin
left a comment
There was a problem hiding this comment.
Since this has the potential to cause unintentional failures for existing users, targeting 8.0 may be the safer option.
|
caretaker: this is for version 8 |
| } | ||
|
|
||
| // ng-add is special because we don't know all possible options at this point | ||
| if (args['--'] && schematicName !== 'ng-add') { |
There was a problem hiding this comment.
Instead of doing schematicName == ng-add why not use a this.validateAdditionalArgs() or maybe a allowAdditionalArgs getter that is false for the base command class, true for add?
People can still ng generate something:ng-add and it would trigger this condition.
There was a problem hiding this comment.
Will follow up on this as I like the idea.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
When an addition argument is parsed the schematic commands should fail with an error.
Fixes #12549