Skip to content

fix(@angular/cli): properly set multi-target command flag #10542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2018

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 30, 2018

Fixes: #10531

@hansl hansl merged commit e997a25 into angular:master May 1, 2018
@clydin clydin deleted the multi-target branch May 1, 2018 00:02
@shahmirn
Copy link

shahmirn commented May 1, 2018

@clydin This doesn't fix the issue with the build command.

build.ts also needs:

public readonly multiTarget = true;

@clydin
Copy link
Member Author

clydin commented May 1, 2018

The build command is intentionally single target. Future versions will support more complex project build pipelines.

@shahmirn
Copy link

shahmirn commented May 1, 2018

This results in an issue where if a 1.x CLI project is updated to 6.x, and then a library is added to it, then the build command fails

I believe it's 'cause when .angular-cli.json is migrated to angular.json, defaultProject is not set.

@filipesilva
Copy link
Contributor

@shahmirn I just tested with a new updated project and I think you're right. defaultProject does not get set but should.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lint is failing for multiple projects
5 participants