The analytics prompt shouldn't run in CI environments

[mattlewis92]

🐞 Bug report

Command (mark with an x)

npm install

Is this a regression?

Yes, the previous version in which this bug was not present was:

v7 and below

Description

When upgrading to v8 the analytics prompt breaks CI as it hangs infinitely waiting for the user to choose to enable it or not

🔬 Minimal Reproduction

Run npm install on a v8 cli project on CI. For example: https://travis-ci.org/mattlewis92/angular-calendar/builds/538499347

Attempting to disable analytics on the project then fails as the config it adds to angular.json is invalid

ng analytics project off

🔥 Exception or Error

🌍 Your Environment

Angular CLI: 8.0.0
Node: 12.1.0
OS: darwin x64
Angular: 8.0.0
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, language-service, platform-browser
... platform-browser-dynamic, router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.800.0
@angular-devkit/build-angular      0.800.0
@angular-devkit/build-ng-packagr   0.800.0
@angular-devkit/build-optimizer    0.800.0
@angular-devkit/build-webpack      0.800.0
@angular-devkit/core               8.0.0
@angular-devkit/schematics         8.0.0
@ngtools/json-schema               1.1.0
@ngtools/webpack                   8.0.0
@schematics/angular                8.0.0
@schematics/update                 0.800.0
ng-packagr                         5.2.0
rxjs                               6.5.2
typescript                         3.4.5
webpack                            4.30.0

Anything else relevant?

The is-ci package could be used to disable that prompt on CI envs: https://www.npmjs.com/package/is-ci

The analytics config needs to be added to the schema so it can be disabled at the project level

The workaround for now is to add this to travis.yml

before_install: npx @angular/cli analytics off

[mgechev]

You can set this flag in your CI to disable the analytics. We'll work on fixing this in the next patch release.

[mattlewis92]

Awesome, thanks @mgechev! btw it might be worth documenting the NG_CLI_ANALYTICS variable here: https://angular.io/analytics

[cyrilletuzi]

I also have this issue. For info: it appeared during the CLI beta phase, then was fixed (it was OK in CLI v8.0.0-rc.4), and is here again in v8.0.0, so a commit between v8.0.0-rc.4 and 8.0.0 reintroduced this issue.