Skip to content

1 start #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adds appropriate types to courses.service.ts
The course is missing the correct types for the `saveCourse` method so that tests were unable to run properly. Looks like this is fixed on the master branch but is not implemented in the 1-start branch.

Changes:

- Adds correct type information to saveCourse method in `course.service.ts`
  • Loading branch information
duncannevin authored Jun 22, 2019
commit 0c279222c062bb28a701f8cc63ca5aa880a20a43
4 changes: 2 additions & 2 deletions src/app/courses/services/courses.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ export class CoursesService {
}


saveCourse(courseId:number, changes: Partial<Course>) {
return this.http.put(`/api/courses/${courseId}`, changes);
saveCourse(courseId:number, changes: Partial<Course>): Observable<Course> {
return this.http.put<Course>(`/api/courses/${courseId}`, changes);
}

findLessons(
Expand Down