This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Fix styling for bootstrap placeholder #879
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon the PR #816 which fixes the styling of bootstrap selects to correctly fit in a form. This PR removes the text-muted style from the placeholder, which while it might have the same color in the default bootstrap, is actually not compatible with the bootstrap less files, so when a bootstrap theme is used, the color is wrong. With the text-muted style, it's difficult to override this.
This PR adds styling to make the placeholder as per the default bootstrap theme, but it can be further styled with less if needed.