This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Fix width calculation to allow for different padding #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs history fixed - there should not be any merge commits. Can you fix the history and package it into one commit? |
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
|
Tidied up into single commit... |
|
An extra semi-colon is failing the build 😞 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the offsetLeft parameter to calculate the input size. It makes the assumption that offsetLeft (which is an available member) is the same as the right side, and then adds some margin.
This allows for different padding to be used, which is what the bootstrap themes do.