This repository was archived by the owner on Oct 2, 2019. It is now read-only.
BugFix: removing the label when new tag is clicked on #1994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
… when clicking on it now the all the test are passing sorry ;)
|
Hi , thanks for submitting this PR. Could you clear the dist folder? Then I can have a good view on your changes. Thanks. |
asiacomeau
pushed a commit
to Mixpo/ui-select
that referenced
this pull request
Apr 4, 2018
added 3 commits
July 15, 2018 17:04
…b.com/shmuel-web/ui-select into BugFix_removingLabelFromNewTagOnClick
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
When creating a new tag and clicking to add it to multi tag select, the tag remains named "Tag(new)" with the label even after it's created.
How to reproduce:
go to this plunker
Create a new tag by typing something then you will see the label added in the select options if you select it via keyboard enter the label vanishes, & the tag is added without the label
but ...
if you select via mouse click the label stays...
description
Desired outcome: When you type in "Tag" the selection screen will show "Tag(new)". When you select "Tag(new)", the actual tag will be called "Tag".
Actual outcome: The created tag is still called "Tag(new)".
images
the bug!
the desired outcome!
the label added to the select option.
thanks!