refactor(choices): avoid setting activeItem on mouseenter

[dimirc]

We were using ng-mouseenter to be able to set the hovered row as the active item, but this caused some lagging as ng-mouseenter was calling for a full $digest.

Could be better just to show a simple hover background change (using css) and avoid doing a $digest.

Demo plunker

[jtheoof]

code consistency: add space before {

[dimirc]

@jtheoof done

[jtheoof]

I might be wrong, but after a quick git-grep it looks like the only place where setActiveItem was being called was from the ng-mouseenter event. Perhaps we can get rid of it in uiSelectController.js.

[dimirc]

@jtheoof yes, its not needed anymore. I just removed it

[jtheoof]

👍 Not sure what went wrong with the build.

[dimirc]

Y just rebuilt it and Travis is fine now

[jtheoof]

Cool, I think it's good to go. Might help #88 but I do not think it's the main performance issue.

[sonphnt]

Hi,

When my ng-model is null at first with placeholder "Please select". Do we have any option to turn off active blue background on the first item of the list. Because that make people confused when user click to open the dropdown and see the first item selected with blue background.

The blue background on item should only be highlighted if ng-model has value when user select one item. Otherwise, we should leave all items in the dropdown list with white background as normal.

Thanks

[kryptografisch]

+1