Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Select2 styles don't render dropdown is positioned 'up' and theme is globally set #1674

Closed
yogeshgadge opened this issue Jun 21, 2016 · 2 comments
Closed

Select2 styles don't render dropdown is positioned 'up' and theme is globally set #1674

yogeshgadge opened this issue Jun 21, 2016 · 2 comments

Comments

@yogeshgadge
Copy link

yogeshgadge commented Jun 21, 2016 •
edited
Loading

Select2 styles don't render dropdown is positioned 'up' and theme is globally set

Plunkr

Click on the Always Up Select
@yogeshgadge yogeshgadge changed the title Styling issues with uiSelectConfig.theme = 'select2' vs. element level directive theme="select2" position="up" Select2 styles don't render dropdown is positioned 'up' and theme is globally set Jun 21, 2016
@hearsid
Copy link
Contributor

hearsid commented Jun 22, 2016

To add more clarity to the issue here is some more information and screenshots.
When select2 theme is globally set and and ui-select-choices is set to position='up' then the styling will not be proper, to make the styling work select2 theme has to be manually added to ui-select by theme="select2" . Here is a specific plunker showing the issue clearly, http://plnkr.co/edit/PN9aMYx8ty1m1TN9td2Y .
How it is looking :
screen shot 2016-06-22 at 12 38 43 pm

How it should look:
screen shot 2016-06-22 at 12 38 52 pm

@hearsid hearsid mentioned this issue Jun 22, 2016
Merged
@hearsid
Copy link
Contributor

hearsid commented Jun 22, 2016

Here is the link for Pull request for the same, #1676. Here is the plunk solving the same, http://plnkr.co/edit/PN9aMYx8ty1m1TN9td2Y

user378230 pushed a commit that referenced this issue Jun 26, 2016
@user378230
fix(select2): Up-direction when using global theme
5336dc5 
select2 theme working well when the direction for the dropdown is set 
to up, earlier it was working only when theme was set by the directive 
and not working for globally set theme.

Closes #1674
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yogeshgadge @hearsid