Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

no-choice.tpl.html is missing from select2 and selectize #1608

Closed
deepak342 opened this issue May 17, 2016 · 7 comments
Closed

no-choice.tpl.html is missing from select2 and selectize #1608

deepak342 opened this issue May 17, 2016 · 7 comments

Comments

@deepak342
Copy link

In the latest release v0.17.1, the no-choice.tpl.html is missing from the $templateCache for the themes "Select2" & "selectize". It seems to be available only for bootstrap

Error:
Failed to load template: select2/no-choice.tpl.html

@user378230
Copy link
Contributor

user378230 commented May 17, 2016

Would you like to submit a PR with templates for these two themes? If its similar to the bootstrap template they should be quite simple files.

If you also fork one of the example plunkrs with a demo so I can verify without pulling down the changes, then I can merge it in much quicker.

@santosguilherme
Copy link

@deepak342, It works with the theme bootstrap?

@deepak342
Copy link
Author

@santosguilherme It does with the bootstrap theme but not with the other two('select2' & 'selectize').

@ghost
Copy link

ghost commented Jun 1, 2016

Hi for me also uiSelectNoChoice works with bootstrap theme but it is not working with select2 and selectize theme. Will there be solution for uiSelectNoChoice directive for ui-select v. 0.17.1 soon?

@user378230 user378230 changed the title no-choice.tpl.html is missing from the $templateCache in the latest release v0.17.1 no-choice.tpl.html is missing from select2 and selectize Jun 8, 2016
@bubenshchykov
Copy link

+1

@user378230
Copy link
Contributor

user378230 commented Jun 15, 2016

@bubenshchykov Please don't +1 issues, you can use github reactions to express your support for a bug fix. In this case you may find it more constructive to submit a PR as the fix isn't too complicated.

@ghost
Copy link

ghost commented Jul 7, 2016

@user378230 Hi I created a pull request for uiSelectNoChoice support for Select2 theme: #1704

Can you please review it and see if it is ok?

user378230 pushed a commit that referenced this issue Jul 7, 2016
Adds uiSelectNoChoice support for the select2 theme

Closes #1608
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants