Dropdown flickering cause opacity set to 0 when filtering

[onemenny]

Please see: http://plnkr.co/edit/erN0pTgEVxBrfJF4p9U7?p=preview
Use the select2 theme and type 'a' and then 'd' you will see that on each letter you type the drop filckers.

It appears that this is cause by line 1091

// Hide the dropdown so there is no flicker until $timeout is done executing.
            dropdown[0].style.opacity = 0;

            // Delay positioning the dropdown until all choices have been added so its height is correct.
            $timeout(function(){
.
.
.
 // Display the dropdown once it has been positioned.
              dropdown[0].style.opacity = 1;
            });

opacity should not change.

[chnldw]

Same here with angular 1.4.7 and ui-select 0.13.2

[cfey]

this fixed it for me as well

[shyamal890]

Linking similar issue #1314

@aaronroberson Can you please have a look at this solution and commit the change to this library.

[aaronroberson]

@shyamal890 Can you direct me to a PR that I can review and accept?

[onemenny]

@aaronroberson look at my pull requests #1371 I already enhanced it with more bug fixes

[aaronroberson]

Any chance you can remove the updates to the dist files and optionally
squash the commits?

On Mon, Feb 8, 2016 at 11:21 PM Menny Rachmanny (onemenny) <
notifications@github.com> wrote:

@aaronroberson https://github.com/aaronroberson look at my pull
requests #1371 #1371 I
already enhanced it with more bug fixes

—
Reply to this email directly or view it on GitHub
#1298 (comment)
.

[onemenny]

Sure, I'll do it later on today.

[onemenny]

@aaronroberson ok, I hope I got it right. everything is squashed and dist is reset.
There are many changes to this pull request and some new test. here are the highlights:

    a. Do not set opacity when typing (causes flickering)
    b. Appen-to-body=true cause loos of focus on tag add/delete, backspace…
    c. Using tags (dashboard tags): type the letter 'a' which should appear in one of the ddl items, then delete the letter (empty search), causes the <'a' new item> to remain in the ddl items
    d. when using closeOnSelect with tagging - hitting the enter key sets the new tag but keeps the search input value
    e. Find dupes: Tags duplication helper method was added (tags may be objects and need comparer function)
    f. Fix ensureHighlight to work only when ctrl.open

[yogeshgadge]

I am going with the following hack for now.

      // Hide the dropdown so there is no flicker until $timeout is done executing.
      if (dropdown[0].clientHeight == 0) {
         dropdown[0].style.opacity = 0;
      }