perf(uiSelectCtrl): moving activate events out of $timeout

Moved the removal of activate events out of the $timeout. This removes additional unneccessary calls to the event handler once the $timeout has been initiated.
angular-ui · Mar 23, 2016 · 926f462 · 926f462
1 parent 6444d6b
commit 926f462
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/uiSelectController.js b/src/uiSelectController.js
@@ -128,14 +128,14 @@ uis.controller('uiSelectCtrl',
         var animateHandler = function(elem, phase) {
           if (phase === 'start' && ctrl.items.length === 0) {
             // Only focus input after the animation has finished
+            ctrl.$animate.off('removeClass', searchInput[0], animateHandler);
             $timeout(function () {
-              ctrl.$animate.off('removeClass', searchInput[0], animateHandler);
               ctrl.focusSearchInput(initSearchValue);
             });
           } else if (phase === 'close') {
             // Only focus input after the animation has finished
+            ctrl.$animate.off('enter', container[0], animateHandler);
             $timeout(function () {
-              ctrl.$animate.off('enter', container[0], animateHandler);
               ctrl.focusSearchInput(initSearchValue);
             });
           }