Skip to content

use $rootScope instead of $scope.$root #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2017

Conversation

zacronos
Copy link
Contributor

@dhilt unfortunately I just found a problem with my prior PR, which has already made it out into rc.3 on npm.

Apparently, in some circumstances I don't fully understand, $scope.$root can be null, causing an exception in the new $scope.$root.$$phase check. The fix in this PR is to check $rootScope.$$phase instead.

I apologize for the inconvenience, but you may want to consider merging this and then releasing a rc.4 build to get ahead of any errors this will cause.

@dhilt dhilt merged commit f79197d into angular-ui:master Oct 27, 2017
@dhilt
Copy link
Member

dhilt commented Oct 27, 2017

@zacronos Of course! as it was her. How do think, is this critical and do we need to release rc.4 immediately? or can it be postponed until next bunch of changes are ready to release?

@zacronos
Copy link
Contributor Author

@dhilt Since I don't really understand why $scope.$root will ever be null, I don't know how likely this is to cause problems for people -- but it did cause an exception in my project which stopped ui-scroll from working once it occurred, so I would say it's better to treat it as critical and release rc.4 immediately.

@dhilt
Copy link
Member

dhilt commented Oct 27, 2017

@zacronos Thanks! will do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants