properly detect digest in progress

[zacronos]

I'm hitting the $digest already in progress error when using applyUpdates with 1.7.0-rc.2 -- this seems to fix the issue for me. I'm not sure exactly how to reproduce the issue, but I can verify the fix at least for my project.

[zacronos]

This might fix #179.

[dhilt]

@zacronos This is why this feature is still in release candidate. It's new and in 1.6 it was just https://github.com/angular-ui/ui-scroll/blob/v1.6.2/src/ui-scroll.js#L336. This is really important part of the component's core and I felt that something's still not okey here. I believe you suggestion is very close to the finalize it. Before accepting this PR, I'd think about writing a test. So if could think about a repro, it will help!

[zacronos]

@dhilt a comment to this SO answer mentions the need for checking $$phase on both scope and root scope, and speculates that is has something to do with isolated scopes. So perhaps if ui-scroll is within the template of a directive with isolated scope, that is when we can duplicate?

If I get the time, I'll try to reproduce with that approach -- however work has gotten very busy for me so we'll see.

[dhilt]

@zacronos Thanks! I'm going to merge it right now, but it needs to be further investigated.

In addition I would like to say that we already have something on that score, I mean the scroll event handler. And you don't see there a !$rootScope.$$phase protection due to it is present in the beginning of function.

[zacronos]

Yep, I did see that, which is why I didn't add the additional guard in that function.

FYI, I forgot to mention that the isolated scope directive scenario I described above is actually the case in my project, so there is supporting evidence that that is when it is necessary.