Make ui-sref accept objects and not only Strings

[mgonto]

Hey,

Sometimes we actually want to link to another state based on a value on scope and not only by text.

I think it might be a good idea to make ui-sref accept values and call $eval on it. I created my own directive for this. You may want to use something similar. I can PR this as well to your code if you guys want.

https://github.com/mgonto/mgo-ui-router-goto/blob/master/uiGoto.js

Thanks!

[timkindberg]

You mean the params right? Yeah I'm thinking we should split ui-sref into two directives (like we already did for the new ui-sref-options directive), ui-sref for the state name and ui-sref-params for the params object. It would be a breaking change but probably worth it.

[mgonto]

Sorry for not being clear. Yeah, I meant the params. You can look at my code, it's actually really simple to implement the $eval on the params object :).

It'd be a breaking change but totally worth it. It makes sense that params aren't "hardcoded string" and actual scope objects IMHO.

Thanks!

[timkindberg]

@nateabele I'm fine with this breaking change. Are you?

@mgonto if nate is fine with it, would you want to submit a pull request (with tests, etc)?

[mgonto]

@nateabele hey nice to talk to you again :).

I'll check and if it's short I'll do the PR now :). I'm going on vacations next week so I'll see if it can be done quickly.

Thanks!

[timkindberg]

Ok that's fine. Cool.

[christopherthielen]

Fixed in 3831af1