Skip to content

ui-sref-active not working for state based (url-less) navigation #738

Closed
@samccone

Description

@samccone

So, some apps do not use urls and instead use state changes.

Thus this line is evaluating to false,

https://github.com/angular-ui/ui-router/blame/86eacac09ca5e9000bd3b9c7ba6e2cc95d883a3a/src/stateDirectives.js#L68

because of this
https://github.com/angular-ui/ui-router/blame/86eacac09ca5e9000bd3b9c7ba6e2cc95d883a3a/src/stateDirectives.js#L66

Essentially checking the states href to determine if state has changed is incorrect.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions