Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expandable): Add 'expandRow' and 'getExpandedRows' #5024

Merged
merged 1 commit into from
Feb 4, 2016

Conversation

rafaelb
Copy link

@rafaelb rafaelb commented Jan 25, 2016

Features required for project I am currently working on.

@swalters
Copy link
Contributor

@rafaelb rafaelb force-pushed the expandable-extend branch 2 times, most recently from 8160b8b to 55e0a3d Compare January 26, 2016 15:49
@rafaelb
Copy link
Author

rafaelb commented Jan 26, 2016

@swalters Done

@JLLeitschuh
Copy link
Contributor

Does this still work for all of the aria roles? Or do those need to be inverted as well?
This seems fine to me otherwise.

@swalters
Copy link
Contributor

@rafaelb To be consistent with our other api methods, can you please change expandRow to toggleRow? This will allow the method to expand or collapse a row.

@rafaelb
Copy link
Author

rafaelb commented Jan 30, 2016

@swalters I think that toggling is already handled by this method: https://github.com/angular-ui/ui-grid/blob/6709846/src/features/expandable/js/expandable.js#L145

For the project we are working on, we needed the ability to expand rows (or not do anything if they are already expanded)
I based this method on the "selectRow" method of the selectable feature:
https://github.com/angular-ui/ui-grid/blob/6709846/src/features/selection/js/selection.js#L177

What I think the best solution would be is to have "expandRow", "collapseRow" and "toggleRow" methods.
What do you think?
If you agree, I will add a "collapseRow" method.

@swalters
Copy link
Contributor

swalters commented Feb 1, 2016

@rafaelb You suggestion is good.

I need these features for a project for a project I am currently working on.

add collapseRow method
@rafaelb
Copy link
Author

rafaelb commented Feb 2, 2016

@swalters Added 'collapseRow' method

swalters added a commit that referenced this pull request Feb 4, 2016
feat(expandable): Add 'expandRow' and 'getExpandedRows'
@swalters swalters merged commit 83af4a2 into angular-ui:master Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants