-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expandable): Add 'expandRow' and 'getExpandedRows' #5024
Conversation
7a0ea9a
to
ee1e625
Compare
@rafaelb please rebase this PR into one commit. thanks. |
8160b8b
to
55e0a3d
Compare
@swalters Done |
Does this still work for all of the aria roles? Or do those need to be inverted as well? |
@rafaelb To be consistent with our other api methods, can you please change expandRow to toggleRow? This will allow the method to expand or collapse a row. |
@swalters I think that toggling is already handled by this method: https://github.com/angular-ui/ui-grid/blob/6709846/src/features/expandable/js/expandable.js#L145 For the project we are working on, we needed the ability to expand rows (or not do anything if they are already expanded) What I think the best solution would be is to have "expandRow", "collapseRow" and "toggleRow" methods. |
@rafaelb You suggestion is good. |
I need these features for a project for a project I am currently working on. add collapseRow method
55e0a3d
to
005ca6a
Compare
@swalters Added 'collapseRow' method |
feat(expandable): Add 'expandRow' and 'getExpandedRows'
Features required for project I am currently working on.