Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ttf path by removing '?'. Resolves webpack issue. #4179

Merged
merged 1 commit into from
Aug 13, 2015
Merged

Fix ttf path by removing '?'. Resolves webpack issue. #4179

merged 1 commit into from
Aug 13, 2015

Conversation

mtraynham
Copy link

This fixes #4113. Simple change.

@JLLeitschuh
Copy link
Contributor

Can you ensure that this doesn't break on some browser?
http://www.paulirish.com/2009/bulletproof-font-face-implementation-syntax/
My css isn't strong enough to just accept this. I don't know why that ? is there and if needs to be there for some particular browser.

@mtraynham
Copy link
Author

Seems the initial commit had it:
ce33097#diff-46456a3b2c603089887395d6c827b689R6

It's just a path reference. Usually you would have query parameters after the ? to cache bust, like so: url('ui-grid.ttf?v=20'), but with nothing afterwards it's pointless to have.

@mtraynham
Copy link
Author

By the way, I'm actually able to resolve this with webpack (no change required for angular-ui-grid), but it was a slight hiccup and felt the question mark is unnecessary...

@JLLeitschuh
Copy link
Contributor

I'll trust it. I asked some other people with more CSS skills than my own and they approve.

JLLeitschuh added a commit that referenced this pull request Aug 13, 2015
Fix ttf path by removing '?'.  Resolves webpack issue.
@JLLeitschuh JLLeitschuh merged commit 7d88c7b into angular-ui:master Aug 13, 2015
@mtraynham
Copy link
Author

thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the css file: in@font-face the '?' in url('ui-grid.ttf?') confuses webpack loader
2 participants