This repository was archived by the owner on Nov 30, 2018. It is now read-only.
fusion tables update when options are changed #1453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the watcher for layer options to call setOptions instead of setting them to null and calling createGoogleLayer. Also, in createGoogleLayer the map was never getting set to the new layer causing all your changes to be lost when createGoogleLayer was called
Where updating layer options, we only want to set the map when show is set to true.
Contributor
|
LGTM |
nmccready
added a commit
that referenced
this pull request
Aug 27, 2015
fusion tables update when options are changed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a patch to address issue #492. this is my first pull request, so if i screwed up, i'm sorry in advance.