Skip to content
This repository was archived by the owner on Nov 30, 2018. It is now read-only.

MarkerSpiderfier in ui-gmap , issue 1021 #1430

Merged
nmccready merged 15 commits into from
Aug 10, 2015
Merged

MarkerSpiderfier in ui-gmap , issue 1021 #1430

nmccready merged 15 commits into from
Aug 10, 2015

Conversation

@nmccready
Copy link
Contributor

@nmccready nmccready commented Aug 9, 2015

This was requested by a company and they were willing to support the effort (funding me).

Issue #1021

<ui-gmap-google-map center='project.map.center' zoom='project.map.zoom' options="map_options">
        <ui-gmap-markers
                models="project.filtered_locations"
                coords="'self'"
                icon="'icon'"
                type="'spider'"
                typeEvents="spiderEvents"
                fit="true"
        >
                </ui-gmap-markers>
    </ui-gmap-google-map>

nmccready
nmccready reviewed Aug 9, 2015
View reviewed changes
grunt/options.coffee
Copy link
Contributor Author

@nmccready nmccready Aug 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sameold wrapping but this should keep OverlappingMarkerSpiderfier local in the closure.

@nmccready
Copy link
Contributor Author

nmccready commented Aug 9, 2015

@cthrax @wrummler

nmccready
nmccready reviewed Aug 9, 2015
View reviewed changes
example/example.html
Copy link
Contributor Author

@nmccready nmccready Aug 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated in #1429 this fixes the example for the website as well.

@nmccready
Copy link
Contributor Author

nmccready commented Aug 9, 2015

Looking for feedback, also prior to merging I need to squash and add angular commit messages.

nmccready
nmccready reviewed Aug 9, 2015
View reviewed changes
example/issue-1021-spiderfier-rerender.html
Copy link
Contributor Author

@nmccready nmccready Aug 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage

@nmccready
Copy link
Contributor Author

nmccready commented Aug 10, 2015

@cthrax merging; let me know if you see something wrong; I'll do a follow up.

nmccready added a commit that referenced this pull request Aug 10, 2015
@nmccready
Merge pull request #1430 from nmccready/markerSpiderfier
14e9101 
MarkerSpiderfier in ui-gmap , issue 1021
@nmccready nmccready merged commit 14e9101 into angular-ui:master Aug 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nmccready