Skip to content
This repository was archived by the owner on Nov 30, 2018. It is now read-only.

Conversation

@rummelsworth
Copy link
Contributor

Attempting to resolve #1385 by using _.get in ModelKey.scopeOrModelVal.

Verified to work against MCVE at #1385, and our main example template seems to run with all functionality and with no console errors.

Unless _.get is already used elsewhere in the source, this introduces a dependency on lodash 3.7.0+.

@cthrax
Copy link
Contributor

cthrax commented Jul 14, 2015

👍 LGTM

rummelsworth added a commit that referenced this pull request Jul 14, 2015
Allow path-like strings to specify nested properties
@rummelsworth rummelsworth merged commit f76a6b9 into angular-ui:master Jul 14, 2015
@rummelsworth
Copy link
Contributor Author

Thanks.

@nmccready nmccready mentioned this pull request Aug 14, 2015
@QuentinFchx
Copy link
Contributor

This commit broke our code.
Our code looks like this:

<ui-gmap-markers models="models" coords="'location'" click="'onClick'">
    <ui-gmap-windows show="show">
        <div ng-non-bindable></div>
    </ui-gmap-windows>
</ui-gmap-markers>
$scope.models = [
{onClick: ()=>{}}
]

Since this commit, this line breaks because click is a string.

EDIT: My bad, this is not due to this commit (I did a quick blame but this is cleary not the cause).
I will dig further and keep you posted. It works in the 2.0 branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

polygons model path isn't working with nested array

4 participants