Skip to content

Add BoundPointerLabels Option #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2016

Conversation

andreytkachenko
Copy link
Contributor

Added new boolean option - boundPointerLabels (default: true).
On True: nothing changed.
On False: pointer label will not stick to the ends of slider.

@ValentinH
Copy link
Member

Could you add a demo please by forking the default jsfiddle? :)

@andreytkachenko
Copy link
Contributor Author

Hi, here is the demo https://jsfiddle.net/andreytkachenko64/2v6173zs/5/

The idea is to allow pointer labels move like it was in 1.x versions

@codecov-io
Copy link

codecov-io commented May 13, 2016

Current coverage is 99.86%

Merging #323 into master will increase coverage by -0.07%

@@           master       #323   diff @@
========================================
  Files           1          1          
  Lines         728        730     +2   
  Methods         0          0          
  Messages        0          0          
  Branches        0          0          
========================================
+ Hits          728        729     +1   
- Misses          0          1     +1   
  Partials        0          0          

Powered by Codecov. Last updated by 5e5c94a...c3b796a

@ValentinH
Copy link
Member

It only works for the value label but don't you think it should have the same behaviour for floor and ceiling labels?

Also unit tests covering your changes are missing.

@andreytkachenko
Copy link
Contributor Author

Only pointer labels are movable, so it is impossible case for floor and ceiling labels because they are fixed in one place (and it is easy to locate them through css). But I didn't find any good way to move this logic to css (instead js parameters).

added new option boundPointerLabels (default: true). If it is false - pointer label will not stick
to the ends of slider.
@ValentinH ValentinH merged commit 1248bd0 into angular-slider:master May 17, 2016
@ValentinH
Copy link
Member

Thanks ! (and sorry for the delay of the merge)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants