Skip to content

Typings Error when using Redux 4.0.0 #521

Closed
@kevinrjones

Description

@kevinrjones

This is a...

  • feature request
  • bug report
  • usage question

What toolchain are you using for transpilation/bundling?

  • @angular/cli
  • Custom @ngTools/webpack
  • Raw ngc
  • SystemJS
  • Rollup
  • Other

Environment

NodeJS Version: 8.4.0
Typescript Version: 2.8.1 (but also tried on earlier version)
Angular Version: 5.2
@angular-redux/store version: 7.1.1
@angular/cli version: (if applicable) 1.7.4
OS: Mac OSX

I'm completely new to Redux and angular/redux and don't know if you are supporting Redux 4.0.0 yet but I'm seeing an issue when using 4.0.0

To reproduce:

Run ng new myapp
add references in package.json to Redux 4.0.0 and @angular-redux/store 7.1.1
in app.module.ts add
import { NgReduxModule } from "@angular-redux/store";

run ng build and you get the following error

ERROR in node_modules/@angular-redux/store/lib/src/components/ng-redux.d.ts(37,14): error TS2416: Property 'dispatch' in type 'NgRedux<RootState>' is not assignable to the same property in base type 'ObservableStore<RootState>'.
  Type 'Dispatch<RootState>' is not assignable to type 'Dispatch<AnyAction>'.
    Type 'RootState' is not assignable to type 'AnyAction'.
node_modules/@angular-redux/store/lib/src/components/ng-redux.d.ts(37,33): error TS2344: Type 'RootState' does not satisfy the constraint 'Action<any>'.
node_modules/@angular-redux/store/lib/src/components/root-store.d.ts(18,24): error TS2344: Type 'RootState' does not satisfy the constraint 'Action<any>'.

Tried this with Redux 3.7.2 and all works as expected. It looks like there are a few updates to the types in 4.0.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions