Update devtools window prop name #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update prop 'devToolsExtension' to '__REDUX_DEVTOOLS_EXTENSION__' - add package redux-devtools-extension for typings - define some typings for window
Was added by mistake
jamesbs
reviewed
Dec 13, 2018
|
Updated backwards compatibility and removed lint-ignore. Btw, this closes #56. |
|
Hi! Great work guys. Any estimation on a release date? |
jamesbs
pushed a commit
to jamesbs/platform
that referenced
this pull request
Jan 7, 2019
* chore(store): update devtools window prop name - update prop 'devToolsExtension' to '__REDUX_DEVTOOLS_EXTENSION__' - add package redux-devtools-extension for typings - define some typings for window * Delete package-lock.json Was added by mistake * fix(devtools): add backwards compatibility * fix(devtools): backwards compat deToolsExtension * Add yarn.lock changes * fix: adjust formatting to comply with prettier
smithad15
pushed a commit
that referenced
this pull request
May 4, 2019
Adds support for the new '__REDUX_DEVTOOLS_EXTENSION__' window property
github-actions bot
pushed a commit
to adrianiy/platform
that referenced
this pull request
Sep 28, 2021
# ngredux-store-v1.0.0 (2021-09-28) ### Bug Fixes * fix eslint ([ab4d1d3](ab4d1d3)) * **build:** No chai for you ([#209](https://github.com/AdrianInsua/platform/issues/209)) ([be35f03](be35f03)) * **deps:** Change zone.js version ([#222](https://github.com/AdrianInsua/platform/issues/222)) ([e62e149](e62e149)) * **example:** Fix local dev mode ([angular-redux#80](https://github.com/AdrianInsua/platform/issues/80)) ([angular-redux#81](https://github.com/AdrianInsua/platform/issues/81)) ([b06721f](b06721f)) * **ngReduxModule:** Generate metadata ([#237](https://github.com/AdrianInsua/platform/issues/237)) ([8b4b9d8](8b4b9d8)) * **package.json:** add redux as dependencies ([angular-redux#132](https://github.com/AdrianInsua/platform/issues/132)) ([5fdeb19](5fdeb19)) ### chore * **build:** use ng-packagr ([angular-redux#37](https://github.com/AdrianInsua/platform/issues/37)) ([dffe23a](dffe23a)), closes [angular-redux#9](https://github.com/AdrianInsua/platform/issues/9) * **linting:** add global tslint rules ([angular-redux#35](https://github.com/AdrianInsua/platform/issues/35)) ([336cc60](336cc60)), closes [angular-redux#4](https://github.com/AdrianInsua/platform/issues/4) ### Features * add bootstraping script ([3fd7b32](3fd7b32)) * add new devtools window prop name ([angular-redux#58](https://github.com/AdrianInsua/platform/issues/58)) ([55b15a6](55b15a6)) * bump angular version to 11.0.5 ([1b8bb72](1b8bb72)) * Introduced a new function called provideStore() which accepts a already created Redux store ([angular-redux#142](https://github.com/AdrianInsua/platform/issues/142)) ([a6c4aaf](a6c4aaf)), closes [angular-redux#141](https://github.com/AdrianInsua/platform/issues/141) * refactor packages to match new ng-packager ([710edef](710edef)) * upgrade to angular 7 ([angular-redux#72](https://github.com/AdrianInsua/platform/issues/72)) ([18d9245](18d9245)), closes [angular-redux#65](https://github.com/AdrianInsua/platform/issues/65) [angular-redux#66](https://github.com/AdrianInsua/platform/issues/66) [angular-redux#67](https://github.com/AdrianInsua/platform/issues/67) [angular-redux#68](https://github.com/AdrianInsua/platform/issues/68) [angular-redux#69](https://github.com/AdrianInsua/platform/issues/69) [angular-redux#70](https://github.com/AdrianInsua/platform/issues/70) [angular-redux#71](https://github.com/AdrianInsua/platform/issues/71) [angular-redux#74](https://github.com/AdrianInsua/platform/issues/74) [angular-redux#79](https://github.com/AdrianInsua/platform/issues/79) * Typescript Port ([angular-redux#33](https://github.com/AdrianInsua/platform/issues/33)) ([33ea991](33ea991)), closes [angular-redux#35](https://github.com/AdrianInsua/platform/issues/35) [angular-redux#36](https://github.com/AdrianInsua/platform/issues/36) [angular-redux#37](https://github.com/AdrianInsua/platform/issues/37) [angular-redux#38](https://github.com/AdrianInsua/platform/issues/38) [angular-redux#39](https://github.com/AdrianInsua/platform/issues/39) [angular-redux#52](https://github.com/AdrianInsua/platform/issues/52) [angular-redux#50](https://github.com/AdrianInsua/platform/issues/50) [angular-redux#55](https://github.com/AdrianInsua/platform/issues/55) [angular-redux#53](https://github.com/AdrianInsua/platform/issues/53) * **aot:** Support AoT - [#223](https://github.com/AdrianInsua/platform/issues/223) ([#226](https://github.com/AdrianInsua/platform/issues/226)) ([a6d7826](a6d7826)) * **dispatch:** Create dispatch decorator ([#385](https://github.com/AdrianInsua/platform/issues/385)) ([4513566](4513566)) ### BREAKING CHANGES * Upgrades Angular dependencies to v7 * **build:** - changes the output to conform to the Angular Package Format. This may cause subtle differences in consumption behaviour - peer dependencies have been corrected to actual dependencies * **linting:** - ConnectArray has been renamed to ConnectArrayDirective - ReactiveConnect has been renamed to ReactiveConnectDirective - Connect has been renamed to ConnectDirective - interfaces with an "I" prefix have had that prefix removed (e.g "IAppStore" -> "AppStore")
github-actions bot
pushed a commit
to adrianiy/platform
that referenced
this pull request
Sep 28, 2021
# @adrian.insua/ngredux-store-v1.0.0 (2021-09-28) ### Bug Fixes * change package names to be user scoped ([c0c9d1d](c0c9d1d)) * fix eslint ([ab4d1d3](ab4d1d3)) * **build:** No chai for you ([#209](https://github.com/AdrianInsua/platform/issues/209)) ([be35f03](be35f03)) * **deps:** Change zone.js version ([#222](https://github.com/AdrianInsua/platform/issues/222)) ([e62e149](e62e149)) * **example:** Fix local dev mode ([angular-redux#80](https://github.com/AdrianInsua/platform/issues/80)) ([angular-redux#81](https://github.com/AdrianInsua/platform/issues/81)) ([b06721f](b06721f)) * **ngReduxModule:** Generate metadata ([#237](https://github.com/AdrianInsua/platform/issues/237)) ([8b4b9d8](8b4b9d8)) * **package.json:** add redux as dependencies ([angular-redux#132](https://github.com/AdrianInsua/platform/issues/132)) ([5fdeb19](5fdeb19)) ### chore * **build:** use ng-packagr ([angular-redux#37](https://github.com/AdrianInsua/platform/issues/37)) ([dffe23a](dffe23a)), closes [angular-redux#9](https://github.com/AdrianInsua/platform/issues/9) * **linting:** add global tslint rules ([angular-redux#35](https://github.com/AdrianInsua/platform/issues/35)) ([336cc60](336cc60)), closes [angular-redux#4](https://github.com/AdrianInsua/platform/issues/4) ### Features * add bootstraping script ([3fd7b32](3fd7b32)) * add new devtools window prop name ([angular-redux#58](https://github.com/AdrianInsua/platform/issues/58)) ([55b15a6](55b15a6)) * bump angular version to 11.0.5 ([1b8bb72](1b8bb72)) * Introduced a new function called provideStore() which accepts a already created Redux store ([angular-redux#142](https://github.com/AdrianInsua/platform/issues/142)) ([a6c4aaf](a6c4aaf)), closes [angular-redux#141](https://github.com/AdrianInsua/platform/issues/141) * refactor packages to match new ng-packager ([710edef](710edef)) * upgrade to angular 7 ([angular-redux#72](https://github.com/AdrianInsua/platform/issues/72)) ([18d9245](18d9245)), closes [angular-redux#65](https://github.com/AdrianInsua/platform/issues/65) [angular-redux#66](https://github.com/AdrianInsua/platform/issues/66) [angular-redux#67](https://github.com/AdrianInsua/platform/issues/67) [angular-redux#68](https://github.com/AdrianInsua/platform/issues/68) [angular-redux#69](https://github.com/AdrianInsua/platform/issues/69) [angular-redux#70](https://github.com/AdrianInsua/platform/issues/70) [angular-redux#71](https://github.com/AdrianInsua/platform/issues/71) [angular-redux#74](https://github.com/AdrianInsua/platform/issues/74) [angular-redux#79](https://github.com/AdrianInsua/platform/issues/79) * Typescript Port ([angular-redux#33](https://github.com/AdrianInsua/platform/issues/33)) ([33ea991](33ea991)), closes [angular-redux#35](https://github.com/AdrianInsua/platform/issues/35) [angular-redux#36](https://github.com/AdrianInsua/platform/issues/36) [angular-redux#37](https://github.com/AdrianInsua/platform/issues/37) [angular-redux#38](https://github.com/AdrianInsua/platform/issues/38) [angular-redux#39](https://github.com/AdrianInsua/platform/issues/39) [angular-redux#52](https://github.com/AdrianInsua/platform/issues/52) [angular-redux#50](https://github.com/AdrianInsua/platform/issues/50) [angular-redux#55](https://github.com/AdrianInsua/platform/issues/55) [angular-redux#53](https://github.com/AdrianInsua/platform/issues/53) * **aot:** Support AoT - [#223](https://github.com/AdrianInsua/platform/issues/223) ([#226](https://github.com/AdrianInsua/platform/issues/226)) ([a6d7826](a6d7826)) * **dispatch:** Create dispatch decorator ([#385](https://github.com/AdrianInsua/platform/issues/385)) ([4513566](4513566)) ### BREAKING CHANGES * Upgrades Angular dependencies to v7 * **build:** - changes the output to conform to the Angular Package Format. This may cause subtle differences in consumption behaviour - peer dependencies have been corrected to actual dependencies * **linting:** - ConnectArray has been renamed to ConnectArrayDirective - ReactiveConnect has been renamed to ReactiveConnectDirective - Connect has been renamed to ConnectDirective - interfaces with an "I" prefix have had that prefix removed (e.g "IAppStore" -> "AppStore")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devToolsExtensionto__REDUX_DEVTOOLS_EXTENSION__The listen-callback still works (at least
STARTwas fired on load, not sure how to testSTOP), and there were no issues with the extension. Dispatching from the extension worked flawlessly.I added the package
redux-devtools-extensionto give users of this library intellisense for the option types when initializing the devtools-enhancer. I decided against importingdevtoolsEnhancerfrom the same package, as it kind of hides if the devtools were connected successfully or not, and theisEnabled-function in@angular-redux/storewould still be required and does a very similar check. So better to rely only onisEnabledif we require it anyways.