compare state and prevState

[TrySound]

There is an optimization in react-redux which compares previous and current state and do not make slice if they are equal. Is it possible to introduce this optimization in ng-redux?

[wbuchwalter]

Yes, I don't see why not.
Do you have a scenario where this optimization would be useful?
I have a hard time picturing slicing as a bottleneck (unless you have 1 mapStateToProps for the whole application, or that kind of bad practice maybe).

[TrySound]

@wbuchwalter One of my cases is something like selecting already selected item, which shoudn't update state and force recalculating slice of same data.

[wbuchwalter]

My question was more about trying to figure out a scenario where what you said would actually cause perf issues.

But anyway, yes it should be easily doable.

On Fri, May 27, 2016 at 5:47 AM -0700, "Bogdan Chadkin" notifications@github.com wrote:

@wbuchwalter A case is something like selecting already selected item, which shoudn't update state and force recalculating slice of same data.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[TrySound]

There is not so big perf issue, but still props recalculating in tens components could be prevented, this will save a bit of memory I think.

[TrySound]

Also nothing will work if somebody will forget to "immutate" store, which can force to follow the most important rule of redux.

[AntJanus]

Added to 4.1.0 roadmap