Skip to content

Conversation

@jsprey
Copy link
Contributor

@jsprey jsprey commented Apr 8, 2021

No description provided.

@sklein94
Copy link
Contributor

sklein94 commented Apr 8, 2021

Is there a reason why we are using npm instead of yarn?
In my opinion the yarn.lock should be added and the readme should be updated.

But even if npm should still be used, the package-lock.json would be missing.

Joshua Sprey and others added 2 commits April 8, 2021 15:13
Co-authored-by: sklein94 <30648955+sklein94@users.noreply.github.com>
@sklein94
Copy link
Contributor

sklein94 commented Apr 8, 2021

Looks good to me

@sklein94 sklein94 merged commit 30fdb17 into angular-dashboard-framework:master Apr 14, 2021
@sklein94 sklein94 deleted the feature/auth_via_headers branch April 14, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants