Add Certificate List Function V2 #669
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resync Back to Master
|
Fixes #563 |
randshell
suggested changes
Jun 28, 2020
openvpn-install.sh
Outdated
| @@ -1309,9 +1338,12 @@ function manageMenu() { | |||
| revokeClient | |||
| ;; | |||
| 3) | |||
| removeOpenVPN | |||
| listcerts | |||
There was a problem hiding this comment.
Please use the same casing as the other functions and remove the added space
openvpn-install.sh
Outdated
| echo " 4) Exit" | ||
| until [[ $MENU_OPTION =~ ^[1-4]$ ]]; do | ||
| read -rp "Select an option [1-4]: " MENU_OPTION | ||
| echo " 3) List Current Issued Certificates" |
There was a problem hiding this comment.
Please use the same casing as the other options
openvpn-install.sh
Outdated
Comment on lines
1305
to
1312
| if [ "${STATUS}" == "V" ]; then | ||
| printf " Valid :: %s :: %s\\n" "$NAME" "$EXPD" | ||
| elif [ "${STATUS}" == "R" ]; then | ||
| #printf " Revoked :: %s :: %s\\n" "$NAME" "$EXPD" | ||
| continue | ||
| else | ||
| printf " Unknown :: %s :: %s\\n" "$NAME" "$EXPD" | ||
| fi |
There was a problem hiding this comment.
Can we use \t instead of multiple spaces?
Closed
psgoundar
commented
Jul 4, 2020
openvpn-install.sh
Outdated
Comment on lines
1305
to
1312
| if [ "${STATUS}" == "V" ]; then | ||
| printf " Valid :: %s :: %s\\n" "$NAME" "$EXPD" | ||
| elif [ "${STATUS}" == "R" ]; then | ||
| #printf " Revoked :: %s :: %s\\n" "$NAME" "$EXPD" | ||
| continue | ||
| else | ||
| printf " Unknown :: %s :: %s\\n" "$NAME" "$EXPD" | ||
| fi |
openvpn-install.sh
Outdated
| echo " 4) Exit" | ||
| until [[ $MENU_OPTION =~ ^[1-4]$ ]]; do | ||
| read -rp "Select an option [1-4]: " MENU_OPTION | ||
| echo " 3) List Current Issued Certificates" |
openvpn-install.sh
Outdated
| @@ -1309,9 +1338,12 @@ function manageMenu() { | |||
| revokeClient | |||
| ;; | |||
| 3) | |||
| removeOpenVPN | |||
| listcerts | |||
randshell
suggested changes
Jul 4, 2020
openvpn-install.sh
Outdated
| while read -r line || [ -n "$line" ]; do | ||
| STATUS=$(echo "$line" | awk '{print $1}') | ||
| NAME=$(echo "$line" | awk '{print $5}' | awk -FCN= '{print $2}') | ||
| EXPD=$(echo "$line" | awk '{if (length($2) == 15) print $2; else print "20"$2}' | cut -b 1-8 | date +"%b %d %Y" -f -) |
There was a problem hiding this comment.
The expiration date is wrong for revoked clients, we should use the column provided instead of calculating it.
Co-authored-by: randomshell <randshell@protonmail.com>
Co-authored-by: randomshell <randshell@protonmail.com>
psgoundar
commented
Jul 5, 2020
randshell
reviewed
Jul 6, 2020
Co-authored-by: randomshell <randshell@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Certificate List function with requested Changed.
Function will List issues Certificates with CN and Validity Dates.