Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added List Certificate Function #587

Closed
wants to merge 42 commits into from

Conversation

psgoundar
Copy link

This is a list function that show all the issues Certificates from the /etc/openvpn/easy-rsa/pki/index.txt file and formats it into a table to show the Status, Name and Expiration Dates.

Copy link
Contributor

@randshell randshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #563

@randshell
Copy link
Contributor

At the moment index.txt contains revoked users too so this function will show them #566

@psgoundar
Copy link
Author

For my personal Use case I need to list revoked users as well to see them. But I can see why that would not be needed. I can take remove all revoked users or potentially in a future update add another submenu to list All or only valid Certificates?

@randshell
Copy link
Contributor

randshell commented Mar 29, 2020

@psgoundar I'd like to see revoked users too but there are some user who asked to not show them #566 (comment).

My previous comment was to link to the issue not to request changes, @angristan will decide on this.

Comment on lines 1284 to 1494
echo " 3) List Current Issued Certificates"
echo " 8) Remove OpenVPN"
echo " 9) Exit"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3, 8, 9?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got multiple other options that I've added to my repo And I was planning on slowly submitting all the changes up to the main repo.
And I didn't want to continually be renumbering the remove and Exit options
Such as:
echo " 1) Add a new user"
echo " 2) Revoke existing user"
echo " 3) List Current Issued Certificates"
echo " 4) List Current Active Users"
echo " 5) Backup Configuration"
echo " 6) Restore Configuration from Backup *Incomplete"
echo " 7) Sync Configuration to Alternate Servers *Incomplete"
echo " 8) Remove OpenVPN"
echo " 9) Exit"

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the appropriate changes for this PR :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I totally Screwed up my branch. I will close this pull Request. And pull another with the neccessary Changes.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok :)

@psgoundar psgoundar closed this May 2, 2020
@psgoundar psgoundar deleted the angristan branch May 2, 2020 06:07
@psgoundar psgoundar restored the angristan branch May 2, 2020 08:37
@psgoundar
Copy link
Author

Repulled Main Repo and Redoing changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants